Images in custom subnav - #16664
Merged
Merged
Images in custom subnav#16664
Conversation
Georges-GNM
force-pushed
the
gl/image-in-custom-subnav-test
branch
from
September 9, 2026 00:45
08a5fb4 to
750b4e2
Compare
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:5d2d9a2f90ad7f08522d4bd61729a7be7fa1aa8382a9daf946f83e04d5f9b06d"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-gl-image-in-custom-subnav-test"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31177"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-8ae44f41d0a3b4ccc1f7b98c87c4417095fdc9c3"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
Georges-GNM
force-pushed
the
gl/image-in-custom-subnav-test
branch
from
September 9, 2026 08:50
750b4e2 to
068ffb7
Compare
7 tasks
6 tasks
Georges-GNM
marked this pull request as ready for review
September 15, 2026 08:55
Contributor
Is this a requirement? What happens if you add an image to a subnav that appears in an article? |
Georges-GNM
force-pushed
the
gl/image-in-custom-subnav-test
branch
from
September 15, 2026 12:34
29f2d14 to
eb13822
Compare
michaelclapham
approved these changes
Sep 15, 2026
michaelclapham
left a comment
Member
There was a problem hiding this comment.
Tested in CODE and on fronts without images and with images it's looking good at various different width breakpoints!
Nice work!!! 😎 🖼️ 🥳
SiAdcock
approved these changes
Sep 16, 2026
SiAdcock
left a comment
Contributor
There was a problem hiding this comment.
Code-wise it looks good. @michaelclapham tested on CODE, so good to go 🚂
|
Seen on PROD (created by @Georges-GNM and merged by @michaelclapham 7 minutes ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the custom subnav model to match the latest facia scala definition (thereby having to regenerate schemas) and displays subnav images correctly (via the generateurl method/fastly resizer)
From the designs, these are only appearing on fronts. There's a slight styling difference compared to a subnav without an image, where the background doesn't span the width of the page, and instead we have white columns on the sides.
How has this change been tested?
Screenshots